Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tag check #3808

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Remove tag check #3808

merged 1 commit into from
Jul 5, 2023

Conversation

sisuresh
Copy link
Contributor

@sisuresh sisuresh commented Jul 5, 2023 •
edited
Loading

Description

The current tag on 2109a16 (v19.12.0rc2) is interfering with this check for the futurenet release because 19 != 20. If this fix is accepted, I'll open an issue to re-enable this check (and make sure it works correctly).

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@sisuresh sisuresh requested a review from graydon July 5, 2023 17:11
graydon
graydon approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@graydon graydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you open a bug to re-enable this and assign to me (I guess blocking testnet? or final?)

@graydon
Copy link
Contributor

graydon commented Jul 5, 2023

r+ c8cfaf3

@latobarita latobarita merged commit 6c004ae into stellar:master Jul 5, 2023
@sisuresh sisuresh mentioned this pull request Jul 5, 2023
Closed
@sisuresh
Copy link
Contributor Author

sisuresh commented Jul 5, 2023

Can you open a bug to re-enable this and assign to me (I guess blocking testnet? or final?)

Here's the issue - #3810.

@graydon graydon mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graydon graydon graydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sisuresh @graydon @latobarita